mssql_session - Handling cases where the data is nil

[frezbo]

same o/p where the code failed:

inspec> sql = mssql_session()
=> MSSQL session
inspec> data = sql.query("SELECT who.name AS [Principal Name] FROM sys.server_permissions what INNER JOIN sys.server_principals who ON who.principal_id = what.grantee_principal_id WHERE what.permission_name = 'Alter any endpoint' AND who.name NOT LIKE '##MS%##' AND who.type_desc <> 'SERVER_ROLE'  ORDER BY  who.name  ;")
=> SQL ResultSet
inspec> s = data.row(0).column('Principal Name')
=> #<DatabaseHelper::SQLColumn:0x00005566f360da10 @name="Principal Name", @row=nil>
inspec> s.value
NoMethodError: undefined method `[]' for nil:NilClass
from /home/frezbo/.gem/ruby/gems/inspec-2.0.17/lib/utils/database_helpers.rb:13:in `value'
inspec> 

[jquick]

Thanks @frezbo ! This is a great addition. Do you mind adding a unit test for this functionality?

You will want to create a file in: test/unit/utils/database_helpers_test.rb

Something like this should work:

# encoding: utf-8

require 'helper'

describe DatabaseHelper do
  describe DatabaseHelper::SQLColumn do
    def column(row = { 'test' => 'value' })
      DatabaseHelper::SQLColumn.new(row, 'test')
    end

    it 'has a valid column value' do
      column.value.must_equal 'value'
    end

    it 'returns empty value when nil row' do
      column(nil).value.must_equal ''
    end
  end
end

[frezbo]

sure, let me bake that up and test

[jquick]

Thanks @frezbo !

[jerryaldrichiii]

Looks good to me, great work @frezbo!