package resource: Fix brew package detection
#2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miah
approved these changes
Feb 22, 2018
This allows for package detection via `brew` to handle cases where a particular package formula exists but is not installed. Signed-off-by: Jerry Aldrich <[email protected]>
jerryaldrichiii
force-pushed
the
ja/fix-osx-package
branch
from
68e4b3a to
8b5be69
Compare
adamleff
suggested changes
Feb 22, 2018
lib/resources/package.rb
Outdated
| } | ||
| # If package exists but is not installed, then `brew` output will not | ||
| # contain `pkg['installed'][0]['version'] | ||
| unless pkg.dig('installed', 0, 'version') |
There was a problem hiding this comment.
unless...else is really frowned-upon in Rubyland.
Let's just make this:
return {} unless pkg.dig('installed', 0, 'version')
# the package is installed, so we build up our pkg info hash
{
name: ...
}There was a problem hiding this comment.
I like that much more. Implemented in latest commit.
Thanks
Signed-off-by: Jerry Aldrich <[email protected]>
jerryaldrichiii
force-pushed
the
ja/fix-osx-package
branch
from
464a007 to
12cf780
Compare
adamleff
approved these changes
Feb 23, 2018
jquick
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for package detection via
brewto handle cases where aparticular package formula exists but is not installed.