Prevent resources from loading if supports check fails #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquick
force-pushed
the
jq/fix_resource_supports
branch
from
68b5e9c to
8486e5e
Compare
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/fix_resource_supports
branch
from
8486e5e to
9f623c1
Compare
clintoncwolfe
approved these changes
Feb 16, 2018
Signed-off-by: Jared Quick <[email protected]>
kagarmoe
pushed a commit
that referenced
this pull request
Feb 19, 2018
* Prevent resources from loading if supports fail. Signed-off-by: Jared Quick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents resources from initializing if we are not on a supported platform. This also fixes the issue where resource_fail/skip were not working correctly when using a where clause on a resource.
Fixes #2662
Signed-off-by: Jared Quick [email protected]