package resource: Fix Windows package detection #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Aldrich <[email protected]>
miah
approved these changes
Feb 12, 2018
jquick
approved these changes
Feb 13, 2018
chris-rock
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2388 modified how the
packageresource handled errors, but in the case of Windows, the handling for when a package was not found was removed.This adds back that handling.
See: https://github.com/chef/inspec/pull/2388/files#diff-843eb1141523e80b4552e5cc8d178fb4L272
Huge shout out to @frezbo and @abheenasylendran for finding this and assisting in troubleshooting this issue!