Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force a default reporter for ad-hoc runners #2610

Merged
merged 2 commits into from
Feb 12, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Feb 12, 2018

There is a potential issue with ad-hoc runners if they do not set a format or reporter. If this happens no reporters run. This change forces a cli report in that case.

Signed-off-by: Jared Quick [email protected]

@jquick jquick requested a review from a team as a code owner February 12, 2018 13:40
@jquick jquick force-pushed the jq/default_reporter_for_dynamic_runners branch from 5b64dcc to dfd8887 Compare February 12, 2018 13:47
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'd also consider adding a test where if someone passes in --format (such as --format documentation) and no --reporter that we don't try and default to CLI in that case as well.

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jquick jquick merged commit da7b7e8 into master Feb 12, 2018
@miah miah deleted the jq/default_reporter_for_dynamic_runners branch May 3, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants