Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve links to Learn Chef Rally #2476

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Improve links to Learn Chef Rally #2476

merged 2 commits into from
Jan 31, 2018

Conversation

tpetchel
Copy link
Contributor

We recently published some updates to Learn Chef Rally that we'd like to highlight.

@tpetchel tpetchel requested a review from a team as a code owner January 23, 2018 03:55
@tpetchel tpetchel added Aspect: Docs Write the Fine Manual Component: Website inspec.io website labels Jan 23, 2018
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tpetchel for that improvement

Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes overall look good. One wording modification I'd like to see for clarity before merge/release.

a.tutorials--link href="https://learn.chef.io/tracks/integrated-compliance/"
i.focus ⪢
| Integrated Compliance with Chef
div Continue your journey here if you're interested in using Chef to correct potential compliance and security issues.
br
p.clear Huge thanks to Annie Hedgpeth for creating all of these fantastic tutorials.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it clear which of the tutorials are Annie's, I suggest changing this line to:

"Huge thanks to Annie Hedgpeth for creating all of the following fantastic tutorials:"

@chris-rock
Copy link
Contributor

@tpetchel Anything we can help to get this in?

@adamleff
Copy link
Contributor

This is a good change as-is so I'll merge it and then put forth a quick one-liner change to update.

@adamleff adamleff merged commit 1295d27 into master Jan 31, 2018
@adamleff adamleff deleted the tp/rally-links branch January 31, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Docs Write the Fine Manual Component: Website inspec.io website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants