Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages resource: Add architectures support #2469

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Conversation

jerryaldrichiii
Copy link
Contributor

This adds support for architectures to the packages resource.

Example:

describe packages(/compat-libstdc++-33/) do
  its('architectures') { should include 'x86_64' }
  its('architectures') { should include 'i686' }
end

This also adds documentation for the packages resource and closes #2463

This adds support for `architectures` to the `packages` resource.

Example:

```
describe packages(/compat-libstdc++-33/) do
  its('architectures') { should include 'x86_64' }
  its('architectures') { should include 'i686' }
end
```

This also adds documentation for the `packages` resource

Signed-off-by: Jerry Aldrich <[email protected]>
@jerryaldrichiii jerryaldrichiii requested a review from a team as a code owner January 18, 2018 04:25
@adamleff adamleff added the Type: Enhancement Improves an existing feature label Jan 19, 2018
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @jerryaldrichiii.

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yay sweet work @jerryaldrichiii thank you for adding architectures 😁

@arlimus arlimus merged commit d96a6af into master Jan 26, 2018
@arlimus arlimus deleted the ja/add-arch-to-packages branch January 26, 2018 07:57
@Wolfsrudel
Copy link

Is this implemented already? It is not working in 1.51.2 on my installation. :/

@adamleff
Copy link
Contributor

It should be working as it was in the 1.51.1 build. Please open a new issue with as much detail as possible so we can troubleshoot it. Thanks.

jerryaldrichiii added a commit that referenced this pull request Feb 1, 2018
This adds support for `architectures` to the `packages` resource.

Example:

```
describe packages(/compat-libstdc++-33/) do
  its('architectures') { should include 'x86_64' }
  its('architectures') { should include 'i686' }
end
```

This also adds documentation for the `packages` resource

Signed-off-by: Jerry Aldrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for checking architecture within package resource
4 participants