Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default cli options to be uniq per command type #2378

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Dec 7, 2017

#2377 was released to solve the default command issue with json-config. While this fix works it makes the default cli commands global. This means any command you run will have these defaults. This could cause unintended issues as shell and other inspec commands will be getting exec defaults.

This change breaks out the defaults by command type so we only load the correct defaults.
Signed-off-by: Jared Quick [email protected]

@jquick jquick requested a review from a team as a code owner December 7, 2017 02:49
@jquick jquick changed the title Update default cli options to uniq per command type Update default cli options to be uniq per command type Dec 7, 2017
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to think ahead, @jquick - thank you very much for this improvement. :)

@adamleff adamleff added the Type: Enhancement Improves an existing feature label Dec 7, 2017
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants