Remove rainbow dependency, fix duplicate rake gem #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manhattan ad-hoc build, version 1.47.3+20171205201338, tested on CentOS 7.3 and Ubuntu 16.04, and issue is resolved. |
miah
approved these changes
Dec 6, 2017
The version of Rainbow brought in as a direct dependency also depends directly on Rake, and our pin of Rake was inaccurate. This was causing Omnibus to build packages that contained two rake gems which would emit "Unresolved specs during Gem::Specification.reset" warnings when running InSpec. Signed-off-by: Adam Leff <[email protected]>
adamleff
force-pushed
the
adamleff/duplicate-rake
branch
from
5697bda to
6540f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Rainbow brought in as a direct dependency also depends directly on Rake, and our pin of Rake was inaccurate. This was causing Omnibus to build packages that contained two rake gems which would emit "Unresolved specs during Gem::Specification.reset" warnings when running InSpec.
Rainbow does not appear to be used anywhere in InSpec, so I'm removing it.
Fixes #2105