Update command resource to check for mock backend #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/check_command_for_mock_backend
branch
from
ea47bf7 to
289609f
Compare
adamleff
approved these changes
Nov 29, 2017
There was a problem hiding this comment.
I think this is a fine approach. Another would be to do inspec.backend.is_a?(Train::Transports::Mock::Connection) but either way, we're tying ourselves to a specific Train implementation detail, and I'd rather name the mock OS something other than "unknown" and leave "unknown" for OSs we literally cannot detect.
|
Fully agree Adam, great points on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the command errors when using a mock backend that does not set a os.name. Ex:
command(docker).exist? is not supported on your OS: unknownThis change goes in tandem with inspec/train#221. It can be merged early if needed but we will not see the errors go away till both are merged and inspec is updated to use the new version of train.
Signed-off-by: Jared Quick [email protected]