wmi resource: properly escape quotes in WMI query #2342
Conversation
Signed-off-by: David Alexander <[email protected]>
Signed-off-by: David Alexander <[email protected]>
adamleff
changed the title
There was a problem hiding this comment.
You know more about Windows than I do, but this seems like a reasonable change. Thanks, @TheLonelyGhost!
| @@ -14,7 +14,7 @@ | |||
| # Use win32_service with filter, it returns a single service object | |||
| describe wmi({ | |||
| class: 'win32_service', | |||
| filter: "name like '%winrm%'" | |||
| filter: 'name like "%winrm%"' | |||
There was a problem hiding this comment.
Isn't this breaking existing users that used the old syntax?
There was a problem hiding this comment.
I'm not sure I understand what you mean. The original test checks if a nested string works with single-quotes (') whereas this test checks against nested double-quotes (").
This small change makes it so the same test covers 2 concepts instead of just one.
Since the wmi resource implementation executes powershell with nested "'s using a string composed with "'s, it makes sense to check that the string given here uses "'s and that it escapes them properly.
Additionally, this line of the test checks that the filter option actually works as expected.
What's the question here? What concern is there about a breaking change?
There was a problem hiding this comment.
Seems like it was late during my review. All good, thank you for catching this one!
| @@ -14,7 +14,7 @@ | |||
| # Use win32_service with filter, it returns a single service object | |||
| describe wmi({ | |||
| class: 'win32_service', | |||
| filter: "name like '%winrm%'" | |||
| filter: 'name like "%winrm%"' | |||
There was a problem hiding this comment.
Seems like it was late during my review. All good, thank you for catching this one!
Fixes #2260.
This modifies an existing test to include that scenario and fixes it as 2 separate commits.