Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http resource: properly support HEAD request with remote worker #2340

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

adamleff
Copy link
Contributor

The existing method of adding -X HEAD to the curl command does not work properly and can cause timeouts because curl doesn't properly close the connection. The correct way is to use curl's own --head flag.

Fixes #2335

The existing method of adding `-X HEAD` to the curl command does not
work properly and can cause timeouts because curl doesn't properly
close the connection. The correct way is to use curl's own `--head`
flag.

Signed-off-by: Adam Leff <[email protected]>
@adamleff adamleff requested a review from a team as a code owner November 27, 2017 16:58
@adamleff adamleff added the Type: Bug Feature not working as expected label Nov 27, 2017
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adamleff

@chris-rock chris-rock merged commit 98db74a into master Nov 27, 2017
@chris-rock chris-rock deleted the adamleff/http-head branch November 27, 2017 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Resource HEAD timeouts
2 participants