Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub_conf resource: correct grub path for RHEL-7-based OS #2332

Merged
merged 1 commit into from
Nov 27, 2017
Merged

grub_conf resource: correct grub path for RHEL-7-based OS #2332

merged 1 commit into from
Nov 27, 2017

Conversation

atomic111
Copy link
Contributor

@atomic111 atomic111 commented Nov 23, 2017 •
edited by adamleff
Loading

Fixes #2331

@atomic111 atomic111 requested a review from a team as a code owner November 23, 2017 11:10
chris-rock
chris-rock approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @atomic111

@chris-rock chris-rock requested a review from adamleff November 23, 2017 16:28
@adamleff adamleff changed the title Correct grub path for rhel 7 based os in grub_conf resource grub_conf resource: correct grub path for rhel 7 based os Nov 27, 2017
@adamleff adamleff changed the title grub_conf resource: correct grub path for rhel 7 based os grub_conf resource: correct grub path for RHEL-7-based OS Nov 27, 2017
@adamleff adamleff added the Type: Bug Feature not working as expected label Nov 27, 2017
adamleff
adamleff approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @atomic111! Verified back through CentOS 7.1 that this appears to be the correct fix.

@adamleff adamleff merged commit 7d95ce8 into inspec:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamleff adamleff adamleff approved these changes

@chris-rock chris-rock chris-rock approved these changes

Assignees
No one assigned
Labels
Type: Bug Feature not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomic111 @chris-rock @adamleff