Update Rubocop to TargetRubyVersion 2.3 #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the Rubocop engine to use 2.3 and addresses the big changes between 2.0 and 2.3. Signed-off-by: Adam Leff <[email protected]>
adamleff
added a commit
that referenced
this pull request
Nov 16, 2017
PR #2311 updated the Rubocop engine to use Ruby 2.3 to evaluate, and the default behavior is to no longer require `.freeze` to be added to string literals that are treated like constants. This caused the pattern match used in the Expeditor version update script to no longer work. Also manually fixing the `lib/inspec/version.rb` file to be correct. Signed-off-by: Adam Leff <[email protected]>
adamleff
added a commit
that referenced
this pull request
Nov 16, 2017
PR #2311 updated the Rubocop engine to use Ruby 2.3 to evaluate, and the default behavior is to no longer require `.freeze` to be added to string literals that are treated like constants. This caused the pattern match used in the Expeditor version update script to no longer work. Also manually fixing the `lib/inspec/version.rb` file to be correct. Signed-off-by: Adam Leff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the Rubocop engine to use 2.3 and addresses the big changes between 2.0 and 2.3.