Habitat build works for all versions, eliminates rake #2301
Conversation
The Habitat plan has been modified to support building from the repo rather than relying on a gem being pushed to RubyGems. This allows us to build current packages at every merge rather than only pushing to Habitat Builder when we promote to stable. This change also enables Expeditor to perform builds for us and removes the dependency on the rake task as it is no longer needed. Signed-off-by: Adam Leff <[email protected]>
adamleff
force-pushed
the
adamleff/habitat-plan
branch
from
cb07d8c to
0672b8c
Compare
| @@ -10,6 +10,9 @@ docker_images: | |||
| build_args: | |||
| - GEM_SOURCE: http://artifactory.chef.co/omnibus-gems-local | |||
|
|
|||
| habitat_packages: | |||
| - inspec | |||
There was a problem hiding this comment.
I believe this needs/should be a key...you might want to optionally export a container to docker hub:
habitat_packages:
- inspec:
export:
- dockerThis would export the current build and tag with a version (MAJOR.MINOR.PATCH-YYYYMMDDHHMMSS), channel (unstable). We can then "promote" the image (e.g. update channel tags) along with the omnibus packages via Expeditor artifact_actions.
There was a problem hiding this comment.
I was going off of the docs which make it seem like it can be a simple string as long as there were no options:
http://expeditor-docs.es.chef.io/configuration/habitat-packages/#habitat_packages
The InSpec docker image is built and consumed in a different way currently that I'd like to change in the future, but for now I need to keep them separate. Expeditor is at least handling the docker stuff for us, so that's cool.
| @@ -24,46 +25,63 @@ pkg_build_deps=( | |||
| ) | |||
There was a problem hiding this comment.
Does it make sense to use scaffolding-ruby here?
There was a problem hiding this comment.
Unless something changed recently, the Ruby scaffolding worked well for rails, etc... but not for standalone ruby projects. Happy to consider a change in the future, but I'd like the focus of this PR to be on the automation of the existing package building vs. refactoring the package.
|
@schisamo thanks for the review! I replied to the comments and happy to Zoom or continue the conversation here in the PR further, for sure. |
|
|
The Habitat plan has been modified to support building from the repo rather than relying on a gem being pushed to RubyGems. This allows us to build current packages at every merge rather than only pushing to Habitat Builder when we promote to stable.
This change also enables Expeditor to perform builds for us and removes the dependency on the rake task as it is no longer needed.