Fix classname in JUnit formatter #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis test is a valid failure and needs to be investigated, also holding off on merging this pending some discussion taking place in #2276 |
The JUnit formatter currently incorrectly uses `class` instead of `classname` as an attribute. Signed-off-by: Adam Leff <[email protected]>
Signed-off-by: Adam Leff <[email protected]>
adamleff
force-pushed
the
adamleff/fix-junit-formatter
branch
from
6326b4e to
f2caa54
Compare
|
Test fixed, updated with suggestion from community members to prefix classname with the profile name to keep things unique and clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JUnit formatter currently incorrectly uses
classinstead ofclassnameas an attribute.Fixes #2276