inspec compliance login: Ensure supplied server has a proper URI scheme #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a user to specify an Automate server without prepending `https://`. Without this, anything using the `url` fetcher will fail because `open` doesn't interpret the argument as a URL. Signed-off-by: Jerry Aldrich <[email protected]>
adamleff
approved these changes
Oct 26, 2017
adamleff
changed the title
https scheme for inspec compliance login
chris-rock
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was discovered whereby a user logging in with
inspec compliance logindid not specifyhttps://in theirSERVERargument. This causes https://github.com/chef/inspec/blob/master/lib/fetchers/url.rb#L146 to fail because https://github.com/ruby/ruby/blob/trunk/lib/open-uri.rb#L33 doesn't interpret the option as a URL.This adds
https://to the front ofoptions['server']if the URI doesn't contain a scheme, thus fixing the issue.