Fix regression when uploading compliance profiles #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing options to `Train` we need to ensure we do not pass the `'target'` key. See: #1646 NOTE: When running `inspec exec` the key is `:target` so it is not removed, but since `options[:backend]` already exists this is not an issue. Signed-off-by: Jerry Aldrich <[email protected]>
adamleff
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
We will eventually need to circle back on how we handle options hashes like this, but this is the right solution given the current design. Thank you @jerryaldrichiii!
adamleff
changed the title
profile upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing options to
Trainwe need to ensure we do not pass the'target'key. See: #1646NOTE: When running
inspec execthe key is:targetso it is not removed, but sinceoptions[:backend]already exists this is not an issue.