Add output for port/protocol for host resource. #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/host-add-port-to-output
branch
from
fac668b to
e7b136e
Compare
jquick
changed the title
This fixes #2085. Port and protocol are now shown in output of the host resource if defined. Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/host-add-port-to-output
branch
from
61271c3 to
29c384e
Compare
adamleff
approved these changes
Oct 3, 2017
lib/resources/host.rb
Outdated
| @@ -113,6 +113,7 @@ def ipaddress | |||
| end | |||
|
|
|||
| def to_s | |||
| return "Host #{hostname} port #{port} proto #{protocol}" if port | |||
There was a problem hiding this comment.
I think this is fine. I'd consider "building" the string instead of the early return so we're not duplicating the "Host hostname" bit... something like this:
def to_s
resource_name = "Host #{hostname}"
resource_name += " port #{port} proto #{protocol}" if port
resource_name
endThere was a problem hiding this comment.
Sounds good, just pushed out a update with the changes. Thanks for the help!
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/host-add-port-to-output
branch
from
8cc993b to
4a3ef8c
Compare
adamleff
approved these changes
Oct 4, 2017
arlimus
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2085. Port and protocol are now shown in output of the host resource if defined.