Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show versions for inspec compliance profiles #2143

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Show versions for inspec compliance profiles #2143

merged 1 commit into from
Sep 13, 2017

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Sep 13, 2017

Automate supports same profile with multiple versions.

Before:

$ be inspec compliance profiles

== Available profiles:

 * CIS AIX 5.3 and AIX 6.1 Benchmark Level 1 admin/cis-aix-5.3-6.1-level1
 * CIS AIX 5.3 and AIX 6.1 Benchmark Level 2 admin/cis-aix-5.3-6.1-level2
 * DevSec Apache Baseline admin/apache-baseline
 * DevSec Apache Baseline admin/apache-baseline

After:

$ be inspec compliance profiles

== Available profiles:

 * CIS AIX 5.3 and AIX 6.1 Benchmark Level 1 v1.1.0 (admin/cis-aix-5.3-6.1-level1)
 * CIS AIX 5.3 and AIX 6.1 Benchmark Level 2 v1.1.0 (admin/cis-aix-5.3-6.1-level2)
 * DevSec Apache Baseline v2.0.1 (admin/apache-baseline)
 * DevSec Apache Baseline v2.0.2 (admin/apache-baseline)

@alexpop alexpop requested a review from a team as a code owner September 13, 2017 21:12
adamleff
adamleff approved these changes Sep 13, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could totally use some unit tests around the output formatting here, but not something we need to tackle for this PR. Thanks, @alexpop!

@adamleff adamleff added the Type: Enhancement Improves an existing feature label Sep 13, 2017
@adamleff adamleff merged commit cf6fdd0 into master Sep 13, 2017
@adamleff adamleff deleted the ap/print-profile-versions branch September 13, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamleff adamleff adamleff approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpop @adamleff