Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XML files #2107

Merged
merged 2 commits into from
Aug 31, 2017
Merged

Add support for XML files #2107

merged 2 commits into from
Aug 31, 2017

Conversation

jonathanmorley
Copy link
Contributor

@jonathanmorley jonathanmorley commented Aug 30, 2017

To address #82

@jonathanmorley jonathanmorley requested a review from a team as a code owner August 30, 2017 13:46
Signed-off-by: Morley, Jonathan <[email protected]>
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @jonathanmorley, and thanks for submitting this PR!

Unfortunately, we currently have an (undocumented, shame on us) anti-nokogiri policy. It causes us too many issues, ranging from causing us issues trying to include it in Chef omnibus releases, to some of our users not being able to install the InSpec gem because their systems don't permit building of native extensions.

Any chance you can rework this to use REXML out of the Ruby stdlib instead?

Signed-off-by: Morley, Jonathan <[email protected]>
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, @jonathanmorley! Thank you for this awesome contribution!

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work and really fast turnaround @jonathanmorley , thank you so much!!!
I wasn't even aware rexml could do all of this from just within the stdlib, Kudos!!

@arlimus arlimus merged commit 3e7d475 into inspec:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants