allow Automate profile dependencies #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy J. Miller <[email protected]>
adamleff
approved these changes
Apr 12, 2017
There was a problem hiding this comment.
I don't know enough about the URL paths on compliance vs. automate, so this review counts as a conditional 👍 for Ruby implementation only and to get us to two 👍 's from maintainers. If @chris-rock approves, this is good for merge.
Thanks for the fix, @jeremymv2!
chris-rock
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1632
The change allows for compliance profiles identified via
compliance: owner_name/profile_namein inspec.yml when the profile is in Automate, not Compliance server. Prior to this change, during the vendoring step, thecompliance_profile_namemethod was only matching for Compliance server URL path, which differs from Automate's URL path slightly so the result was alib/bundles/inspec-compliance/target.rb:84:incompliance_profile_name': undefined method[]' for nil:NilClass (NoMethodError)error.@targetTested and validated it works for both vendoring/uploading a meta-profile to Compliance Server AND Automate.
Signed-off-by: Jeremy J. Miller [email protected]