Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Adding a website acceptance environment #1634

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Conversation

adamleff
Copy link
Contributor

@adamleff adamleff commented Apr 5, 2017

If changes are detected in the docs or www directory, a website build will be generated that pushes up to Netlify. This will allow teams to validate web changes without requiring pulling down the branch and building locally.

@adamleff adamleff force-pushed the adamleff/netlify branch 8 times, most recently from 2bfb47e to fd5785b Compare April 6, 2017 17:42
@adamleff adamleff changed the title DO NOT MERGE: testing Netlify [www] Adding a website acceptance environment Apr 6, 2017
@adamleff adamleff requested review from arlimus and chris-rock April 6, 2017 17:44
@adamleff adamleff force-pushed the adamleff/netlify branch 2 times, most recently from 96e4945 to 7889156 Compare April 6, 2017 18:14
@chris-rock
Copy link
Contributor

@adamleff Awesome work. I was just thinking about the ci directory. Would www/ci a better place?

@adamleff
Copy link
Contributor Author

adamleff commented Apr 6, 2017

I'd prefer to leave it there for future reasons. Depending on whether we do the auto-bumping, we'll need a place for other CI-related scripts and this felt like a good spot. I'd be happy to mirror Habitat and put it in support/ci instead if you feel strongly about it being in the top-level of the repo... but I don't think we should put it in the www directory.

@chris-rock
Copy link
Contributor

@adamleff Very good proposal. I am preferring support/ci over top-level ci.

@adamleff
Copy link
Contributor Author

adamleff commented Apr 9, 2017

Sounds good. I'll change it when I'm back from PTO later this week.

If changes are detected in the docs or www directory, a website
build will be generated that pushes up to Netlify. This will allow
teams to validate web changes without requiring pulling down the
branch and building locally.

Signed-off-by: Adam Leff <[email protected]>
Per PR feedback, moving the CI scripts directory from the repo root.

Signed-off-by: Adam Leff <[email protected]>
@adamleff
Copy link
Contributor Author

@chris-rock directory moved to support/ci and tests are green. Ready for re-review.

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is sweet. Thank you @adamleff

@chris-rock chris-rock merged commit ad77b88 into master Apr 12, 2017
@chris-rock chris-rock deleted the adamleff/netlify branch April 12, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants