Fix ObjectTraverser when accessing array values #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleff
force-pushed
the
adamleff/fix-object-traverser-for-arrays
branch
3 times, most recently
from
8dea5bb to
ea9e750
Compare
chris-rock
approved these changes
Mar 15, 2017
| end | ||
|
|
||
| it 'captures a hashmap of entries of a line' do | ||
| _(resource.params[0]).must_be_kind_of Hash | ||
| end | ||
|
|
||
| it 'gets params by header fields' do | ||
| _(resource.params[0]['addressable']).must_equal 'ast' | ||
| _(resource.params[0]['name']).must_equal 'addressable' |
There was a problem hiding this comment.
man, who wrote this in the first place :-)
|
|
When attempting to access array values via the `json` resource:
```
describe json('/tmp/test.json') do
its(['array',0]) { should eq "zero" }
end
```
... the resulting data would be an array of the size of the original array
with all the values replaced with nils:
```
expected: "zero"
got: [nil, nil, nil]
```
This was due to a bug in the ObjectTraverser mixin that mapped array values
back through `extract_value` rather than properly handling the passed-in
key(s). This worked fine for the specific data format created by the `csv`
resource but did not work `json` or any other resource that subclassed the
`JsonConfig` resource.
This change fixes the logic when dealing with an array when it's encountered,
and fixes up the `csv` resource with its own `value` method.
This change also adds tests for ObjectTraverser.
Signed-off-by: Adam Leff <[email protected]>
chris-rock
force-pushed
the
adamleff/fix-object-traverser-for-arrays
branch
from
ea9e750 to
4f2b663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to access array values via the
jsonresource:... the resulting data would be an array of the size of the original array
with all the values replaced with nils:
This was due to a bug in the ObjectTraverser mixin that mapped array values
back through
extract_valuerather than properly handling the passed-inkey(s). This worked fine for the specific data format created by the
csvresource but did not work
jsonor any other resource that subclassed theJsonConfigresource.This change fixes the logic when dealing with an array when it's encountered,
and fixes up the
csvresource with its ownvaluemethod.This change also adds tests for ObjectTraverser.
Fixes #1560