Add FreeBSD support for ZFS datasets and pools #1501
Conversation
jbenden
force-pushed
the
jbenden/freebsd-zfs
branch
2 times, most recently
from
2cee66d to
f353986
Compare
There was a problem hiding this comment.
@jbenden Thanks for your contribution! I'm a huge fan of ZFS... used it a lot on OmniOS at my last job... so adding ZFS support fills me with glee. :)
I added a few comments, and we should add some unit tests to this with some mocked output for all the items changed/added (i.e. BSD mounts, ZFS pools, and ZFS datasets). I'd be happy to help you navigate that process if you need any assistance.
lib/resources/mount.rb
Outdated
| end | ||
|
|
||
| class LinuxMounts < MountsInfo | ||
| include MountParser |
There was a problem hiding this comment.
This is probably a good time to rename this to LinuxMountParser to avoid any confusion.
lib/resources/mount.rb
Outdated
| def initialize(inspec) | ||
| @inspec = inspec | ||
| end | ||
| end |
There was a problem hiding this comment.
Should we add a default #parse_mount_options method here that raises an exception to make it clear for future users that the method is required?
| " | ||
|
|
||
| def initialize(zfs_dataset) | ||
| return skip_resource 'The `zfs_dataset` resource is not supported on your OS yet.' if !inspec.os.bsd? |
There was a problem hiding this comment.
We don't need to account for it in this PR, but I suspect this resource would work OK as-is on Solaris and any Linux that is using ZFS-on-Linux too, with the small exception of the actual ZFS binary paths may be different. This is worth some investigation.
There was a problem hiding this comment.
Would love to see the Solaris support for this as well!
The following new resources have been added; however, they presently only support FreeBSD and similar. * `zfs_dataset`: tests if a named ZFS dataset is present and/or has certain properties. * `zfs_pool`: tests if a named ZFS pool is present and/or has certain properties. Additionally, the `mount` resource has been reworked to include support for FreeBSD; while the existing class was renamed to LinuxMountParser. Unit-tests were added for all of the above. Signed-off-by: Joseph Benden <[email protected]>
jbenden
force-pushed
the
jbenden/freebsd-zfs
branch
from
f353986 to
1fdecc6
Compare
|
Hello Adam, I have made all requested modifications; with the exception of supporting Solaris and Linux ZFS. If you have access to either of these operating systems (especially Solaris) I simply need the binary path locations. I am positive this would work with Solaris, but am not sure where the required binaries are... I did see that Linux places them in |
|
@chris-rock I think we should accept this as-is and open an enhancement issue for the backlog to extend this to Solaris-variants and even perhaps Linux-on-ZFS users. But since the contributor doesn't have access to a Solaris-based machine, it seems reasonable to accept as-is. Thoughts? |
|
I agree with you @adamleff |
|
@jbenden thanks again for this contribution! |
The following new resources have been added; however, they presently only support FreeBSD and similar.
zfs_dataset: tests if a named ZFS dataset is present and/or has certain properties.zfs_pool: tests if a named ZFS pool is present and/or has certain properties.The
mountresource has been refactored to include support for FreeBSD too.