feature: bring back profile check #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res | ||
| end | ||
|
|
||
| def check # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity |
There was a problem hiding this comment.
Can we add a short description of expected return values?
There was a problem hiding this comment.
Good point, thank you for pointing this out!
|
This PR has passed 'Verify' and is ready for review and approval! |
|
thank you very much @arlimus |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Oct 26, 2015
Merged change 217ee46b-1a88-46a9-86a5-f65209c2d3eb From review branch profile-check into master Signed-off-by: chartmann <[email protected]>
|
Change: 217ee46b-1a88-46a9-86a5-f65209c2d3eb approved by: @chris-rock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check a profile; exit code 1 if the check finds any errors; 0 otherwise; print warnings