Add negate! support for describe.one object #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pop <[email protected]>
Signed-off-by: Alex Pop <[email protected]>
Signed-off-by: Alex Pop <[email protected]>
Signed-off-by: Alex Pop <[email protected]>
Signed-off-by: Alex Pop <[email protected]>
chris-rock
approved these changes
Jan 30, 2017
There was a problem hiding this comment.
Awesome improvement for the test coverage of the InSpec objects @alexpop
| format("describe.one do\n %s\nend", all_tests) | ||
| if @negated | ||
| # We don't use the describe.one wrapper when negated because: | ||
| # !(test1 || test2) same as (!test1 && !test2) where && is implicit in inspec |
There was a problem hiding this comment.
Thank you for the explanation
| @@ -67,7 +67,7 @@ def rb_describe | |||
| itsy = xtra.nil? ? 'it' : 'its(' + xtra.to_s.inspect + ')' | |||
| naughty = @negated ? '_not' : '' | |||
| xpect = defined?(@expectation) ? expectation.inspect : '' | |||
| if matcher == 'match' | |||
| if @expectation.class == Regexp | |||
There was a problem hiding this comment.
Great improvement, to cover regular expression handling for all kind of matchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added unit tests for the other Inspec resources that were missing them.