revert style changes temporarily #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victoria Jeffrey <[email protected]>
|
@chris-rock @dominik just gonna merge it to get the failures out of the way. Hannah and I are working on a PR to re-introduce the icon changes with corrected tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this commit: ff16583
and the following commit:
1338c39
some changes were made to the styles in rspec_json_formatter, but tests were not updated to reflect these changes.
This commit fixes the failures on master.
The plan is to re-introduce those changes in separate prs where the tests are also addressed to ensure everything is passing. cc @hannah-radish