Add --cache option to inspec exec
#1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still have a lot of inconsistency around whether we want to call it the |
|
@stevendanna I like the wording |
chris-rock
reviewed
Sep 21, 2016
| @@ -1,5 +1,4 @@ | |||
| # encoding: utf-8 | |||
| require 'inspec/dependencies/vendor_index' | |||
There was a problem hiding this comment.
should we rename vendor_index to cache then?
There was a problem hiding this comment.
Good call. I think I've completed the rename in my latest commit.
stevendanna
commented
Sep 21, 2016
| @@ -58,6 +58,8 @@ def self.exec_options | |||
| desc: 'Use colors in output.' | |||
| option :attrs, type: :array, | |||
| desc: 'Load attributes file (experimental)' | |||
| option :cache, type: :string, default: File.expand_path('~/.inspec/cache'), | |||
There was a problem hiding this comment.
Per discussion, let's nuke this default, the Cache class already has one.
This allows users to run: inspec exec ./ --cache PATH which will use `PATH` as the dir to retrieve and store remote dependencies. The hope is that this can eventually be used with `inspec vendor PATH` to package up a profile for offline use. Signed-off-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
ssd/customcache
branch
from
3cba041 to
2d28c78
Compare
chris-rock
approved these changes
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to run:
inspec exec ./ --cache PATH
which will use
PATHas the dir to retrieve and store remotedependencies. The hope is that this can eventually be used with
inspec vendor PATHto package up a profile for offline use.Signed-off-by: Steven Danna [email protected]