Optimize tutorial #1101
Merged
Optimize tutorial #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
bd69892 to
b0d59ec
Compare
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
b0d59ec to
3325c52
Compare
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
3325c52 to
10154c1
Compare
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
10154c1 to
ae8fcb9
Compare
arlimus
force-pushed
the
chris-rock/optimize-tutorial
branch
from
ae8fcb9 to
0fe251a
Compare
|
huge work, thank you!! Let's sync on this, it currently fails to build the static site. |
arlimus
reviewed
Sep 21, 2016
| "start": "node --max-old-space-size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server --config config/webpack.config.js & open http://localhost:8080/", | ||
| "dev": "node --max-old-space-size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server --config config/webpack.config.js --inline --progress --hot --profile --colors --watch --display-error-details --display-cachedwebpack-dev-server & open http://localhost:8080/" | ||
| "start": "open http://localhost:8080/ && node --max-old-space-size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server --config config/webpack.config.js", | ||
| "dev": "open http://localhost:8080/ && node --max-old-space-size=4096 ./node_modules/webpack-dev-server/bin/webpack-dev-server --config config/webpack.config.js --inline --progress --hot --profile --colors --watch --display-error-details --display-cachedwebpack-dev-server" |
There was a problem hiding this comment.
The open command doesn't work across systems. This will essentially fail the build to display anything.
|
The default seems a bit tiny, there's also a search-bar on the right hand side (not sure this is new, but meh 😁 )
|
|
I really like the small logo, well done!! |
|
Also, I'd prefer not to have any plugins as part of the online demo (but let's discuss). |
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
0fe251a to
e5d05e8
Compare
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
e5d05e8 to
bbcd890
Compare
chris-rock
force-pushed
the
chris-rock/optimize-tutorial
branch
from
bbcd890 to
4dd827b
Compare
|
Thank you for the countless improvements in this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is doing some PR improvements:
Still to do:
inspec shell -c 'sshd_config.Protocol'orinspec exec examples/inheritancefixes #1045
fixes #1089
fixes #957
fixes #1086
addresses most issues from #851