-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add demo content #1033
add demo content #1033
Conversation
fe79913
to
6d0537f
Compare
@vjeffrey rebased |
7e04bbc
to
3659cc9
Compare
i'm not handling the shell commands well yet -- that's what the appveyor errors are related to as well -- working on what i need to do there -- but the last few commits changed it so 1) we load instructions directly from json file 2) we match the command input against the keys in the array we got from json file for commands.....still many things/details to figure out. and formatting stuff around instructions. i'll push more commits as i go on.. @chris-rock |
27ce0b6
to
d89abf4
Compare
d89abf4
to
d82af0e
Compare
170f3e9
to
d8da511
Compare
d8da511
to
8ce8c54
Compare
be8b51f
to
b6c75a2
Compare
b6c75a2
to
3f813ab
Compare
k, take a look, try it out!!! i squashed and rebased. the shell commands problem is still a problem, but the other stuffzzzz are working :) |
3f813ab
to
ca4fefc
Compare
fixes #1021 |
fixes #957 |
Great improvement @vjeffrey Its so cool to see this all generated. I have a couple of ideas for future PRs to improve the user experience:
|
yes! all those things! i just pushed a commit so the shell commands work now. -- eh, some of em work, working on it. |
729ad32
to
a41c2b9
Compare
a41c2b9
to
344cd4f
Compare
26ae4f7
to
0bacb7b
Compare
these three things I can't seem to figure out how to do or have no clue at all how to do:
we're matching describe and control blocks now, but it's pretty light matching (see comment in app component). would love some help/ideas/advice on how to make that better the bottom part of the terminal kinda disappears off the screen when the instructions are too big...need to fix that also, the transport options stuff. should get that done. no idea how to do that. ...my readme is a little silly. I can un-silly that if ppl want me to :) |
8c47756
to
5898293
Compare
2c933dc
to
1b1fc9a
Compare
e00e27f
to
2a97d4c
Compare
2a97d4c
to
e9e05b4
Compare
oh also, i added the inspec logo to the top left. feel free to take it out if you don't like how it looks, i was just trying it out :) |
Great work @vjeffrey we cover the open points in another iteration. |
e9e05b4
to
66e54b6
Compare
TODO: (sept 8)