-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use winrm v2 #1018
use winrm v2 #1018
Conversation
3377214
to
8a6c77c
Compare
8a6c77c
to
52f2e10
Compare
52f2e10
to
9699995
Compare
@@ -18,5 +18,5 @@ | |||
|
|||
# ensure that we do not require a newline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment implies that the property we were trying to test was explicitly that the user doesn't need to supply the line ending; but the change to the test implies they now do have to provide the line ending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, let me double-check that
9699995
to
1234ca5
Compare
1234ca5
to
058e960
Compare
058e960
to
2dbcbb6
Compare
👍 An alternative to mutating the text that we get back would be to move the "indifferent to linespace ending" behavior into the matcher. |
@stevendanna i tried that first, but other powershell methods like |
This PR depends on the following PRs to be merged: