improve suse 11 support for service resource #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/suse-11
branch
from
155a40b to
1a1d315
Compare
chris-rock
force-pushed
the
chris-rock/suse-11
branch
from
1a1d315 to
1a4ac0e
Compare
chris-rock
force-pushed
the
chris-rock/suse-11
branch
from
1a4ac0e to
5429ab2
Compare
chris-rock
force-pushed
the
chris-rock/suse-11
branch
from
5429ab2 to
9698901
Compare
| if !os.linux? | ||
| STDERR.puts "\033[1;33mTODO: Not running #{__FILE__} because we are not on linux.\033[0m" | ||
| unless ['ubuntu', 'centos', 'amazon', 'fedora'].include?(os[:name]) | ||
| STDERR.puts "\033[1;33mTODO: Not running #{__FILE__} because we are not on ubuntu, centos, amazon or fedora.\033[0m" |
There was a problem hiding this comment.
just a tiny one: how about
supported = %w{ubuntu centos amazon fedora}
unless supported.include?(os[:name])
STDERR.puts " .... #{supported.join(', ')}...."
chris-rock
force-pushed
the
chris-rock/suse-11
branch
from
9698901 to
3ddcb4c
Compare
|
Some love for Suse, thank you @chris-rock !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #997