Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support lots of groups (was: Consider exposing proxy_buffer_size in Nginx configuration) #701

Closed
stevendanna opened this issue Jun 27, 2019 · 3 comments
Labels
auth-team anything that needs to be on the auth team board automate-auth bug 🐛 Something isn't working

Comments

@stevendanna
Copy link
Contributor

Response headers from dex can be very large if the user has a large set of LDAP groups being returned. While the auth team is looking at providing solutions to the underlying problems, it may be helpful for some users to have access to the proxy_buffer_size nginx configuration so they can accommodate header information larger than 4k. (Alternatively, we could bump the default size to something we think is reasonable and not make it configurable).

@srenatus
Copy link
Contributor

Thanks for creating this issue. For LDAP, you can limit the returned groups using a group search filter; the same trick isn't available to your when using SAML. So, the issue is more apparent and annoying in the SAML case.

@srenatus srenatus changed the title Consdier exposing proxy_buffer_size in Nginx configuration Consider exposing proxy_buffer_size in Nginx configuration Jun 27, 2019
@srenatus srenatus added automate-auth bug 🐛 Something isn't working labels Jul 10, 2019
@srenatus
Copy link
Contributor

Alternatively, we could change the protocol between the UI and session-service. The too-big-headers occurr when session-service, after having gotten the id_token (and, if possible, a refresh_token) from Dex will hand it over to the UI by redirecting to it with the id_token in the URL fragment. That redirect header is what can get too large.

Alternatively, it could just redirect with no token in it, and the UI code could first try to get an id_token from some session-service endpoint (or try to do a /session/refresh), and be given the token in the API response. That way, they could be arbitrarily large.

The problems here are:

  1. The UI code's auth handling is wonky -- there's no "hold it, we'll get a fresh token first" logic; if a different API request happens first, it'll get a 401, and the UI will send the user back to the login screen
  2. The UX with having a giant id_token is largely unknown. It could be sluggish? It's currently sent with any request, so, it'll cause some extra traffic.

@srenatus srenatus changed the title Consider exposing proxy_buffer_size in Nginx configuration Better support lots of groups (was: Consider exposing proxy_buffer_size in Nginx configuration) Jul 10, 2019
@susanev susanev added auth-team anything that needs to be on the auth team board and removed auth-team anything that needs to be on the auth team board labels Jul 11, 2019
@susanev
Copy link
Contributor

susanev commented Mar 10, 2020

this work has been deprioritized, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-team anything that needs to be on the auth team board automate-auth bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants