Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace membership_id with user's id #3096

Closed
4 tasks
tylercloke opened this issue Mar 13, 2020 · 1 comment
Closed
4 tasks

Replace membership_id with user's id #3096

tylercloke opened this issue Mar 13, 2020 · 1 comment
Labels
auth-team anything that needs to be on the auth team board tech debt This issue addresses tech debt in our code base

Comments

@tylercloke
Copy link
Contributor

Description

The membership APIs for teams still use the GUIDs that were used as the V1 IDs for users to associate users with a team. In v2, they are called membership_ids. A migration is required to replace the GUID use in the user_team_assocation table with user IDs. We also need to update association APIs to use the normal IDs, including their use in the UI. We can then drop the membership_id field (or deprecate it and return the normal ID in that field for now for backwards compatibility).

Acceptance Criteria

  • Migrate user_team_assocation table to replace v1 user GUIDS with v2 user IDs. We'll need to list all users to map the GUIDs to IDs. We should drop any GUID that doesn't map to an ID.
  • Update APIs, validation, and docs around team user association APIs as needed.
  • Update the UI to use the ID as the input to the team user association APIs (remove VersionizeTeam helpers, etc).
  • Drop the membership_id field from the user APIs or deprecate it and return the normal ID if we are uncomfortable removing it.
@tylercloke tylercloke added the auth-team anything that needs to be on the auth team board label Mar 13, 2020
@susanev susanev added this to the Auth: Sprint 10 milestone Mar 13, 2020
@tylercloke tylercloke added v2 force upgrade branch tech debt This issue addresses tech debt in our code base labels Mar 13, 2020
@susanev susanev removed this from the Auth: Sprint 10 milestone Mar 16, 2020
@susanev susanev added this to the Auth: Sprint 14 milestone Apr 15, 2020
@susanev susanev removed this from the Auth: Sprint 14 milestone Apr 29, 2020
@susanev
Copy link
Contributor

susanev commented Oct 4, 2020

this work has been deprioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-team anything that needs to be on the auth team board tech debt This issue addresses tech debt in our code base
Projects
None yet
Development

No branches or pull requests

2 participants