$(selector, context) uses wrong context

[Philipp15b]

I'm not sure whether this is intended behavior: When using $(selector, context), cheerio uses the parent context instead of the provided one. This leads to unintentionally searching the object's siblings too.

I find this confusing, because jQuery uses the context directly - this means it behaves exactly like calling find:

Internally, selector context is implemented with the .find() method, so $( "span", this ) is equivalent to $( this ).find( "span" ).

(from the jQuery Docs)

[Philipp15b]

Is this maybe related to #70?

[davidchambers]

I'm not sure whether this is intended behavior

This certainly sounds unintentional.

[ssmout]

This sounds like the problem I've been having in cheerio 0.10.5 and up. It worked in 0.10.4. I also commented about this on #167.

[fb55]

I tried to implement proper context handling in CSSselect yesterday, but apparently my approach didn't handle all cases. When I find some time, I'll have a second look at it.

[trevorsheridan]

I'm experiencing this issue too. I'm trying to do something similar to the following and it seems like it's using the parent or root as the context.

$("section").each(function(index, element) {
    var url = $("a", this).attr("href");
});

[trevorsheridan]

@ssmout is right, it does work in 0.10.4. I suppose I will use this for now.

[skerit]

This issue is still present in 0.11. Using version 0.10.4 still works.

[davidchambers]

Fixed in a47bc68. I think this warrants bumping to 0.12.0, @matthewmueller.

[Philipp15b]

👍 This is a breaking change, so a note in the README would be nice too.

[davidchambers]

Or in History.md.

[matthewmueller]

Updated to 0.12.0. Thanks guys