QR code scanning failing sometimes

[r10s]

scanning a QR codes for setting up a contact sometimes fails with an error; encountered with yggmail, however, it might also be a general issue.

this is the error message that pops up:

[r10s]

this is where the error message is generated in core https://github.com/deltachat/deltachat-core-rust/blob/master/src/securejoin.rs#L288

[adbenitez]

maybe related:

if you scan a QR, then your friend was not online etc. so you cancel the process, the app is in an state that you can't scan a QR again, it will fail until you restart the app

[adbenitez]

ok, this is reproducible and probably a core issue, it is as I said previously, the issue is that a previous QR join haven't completed:

1. prepare two devices, one online (device A) and another offline (device B)
2. with A scan the QR of B to verify B.
3. then scan B's QR again or any other invitation QR.
4. you will get this "QR process failed" dialog.

Logs when you scan a second time after a join-invite is still pending

08-18 12:03:21.593 19744 19793 I DeltaChat: src/qr.rs:51: Scanned QR code: OPENPGP4FPR:7F050495CA095B07AF3BD6B77A7819300E38A7D4#a=USER%40disroot.org&n=&i=XGYA-5U8ds6&s=deWPeeHMQS2
08-18 12:03:24.633 19744 19793 I DeltaChat: src/securejoin.rs:299: Requesting secure-join ...
08-18 12:03:24.633 19744 19793 I DeltaChat: src/qr.rs:51: Scanned QR code: OPENPGP4FPR:7F050495CA095B07AF3BD6B77A7819300E38A7D4#a=USER%40disroot.org&n=&i=XGYA-5U8ds6&s=deWPeeHMQS2
08-18 12:03:24.635 19744 19793 W DeltaChat: src/securejoin.rs:286: Fatal joiner error: A setup-contact/secure-join protocol is already running
08-18 12:03:24.636 19744 19793 E DeltaChat: QR process failed
08-18 12:03:24.636 19744 19793 W DeltaChat: deltachat-ffi/src/lib.rs:2015: failed dc_join_securejoin() call: A setup-contact/secure-join protocol is already running

[adbenitez]

this issue has been there since always, sounds like something that should be solved as part of #2507

[r10s]

this issue has been there since always

thanks for summing up and for the great report!

i first have seen the issue on the m1 meeting where we canned lots of codes on yggmail testing - might be the issue became more visible by that.

so, if the issue is there "since always", it is no blocker for 1.22, however, if we manage to fix it before, it would be great, of course. i would not see that necessarily as a part of #2507, however.