refactoring(sql): recreate config table with UNIQUE constraint

Migration 71 relying on set_config() was added
in early 2021. It is simply removed,
worst case that happens if you upgrade a pre-71 version
to the current one is that you will not have a configured_provider
and will not use provider database settings.
This is already what happens if your provider was added
after configuring.

Author: link2xt

src/sql.rs

@@ -572,22 +572,15 @@ impl Sql {
     pub async fn set_raw_config(&self, key: &str, value: Option<&str>) -> Result<()> {
         let mut lock = self.config_cache.write().await;
         if let Some(value) = value {
-            let exists = self
-                .exists("SELECT COUNT(*) FROM config WHERE keyname=?;", (key,))
-                .await?;
-
-            if exists {
-                self.execute("UPDATE config SET value=? WHERE keyname=?;", (value, key))
-                    .await?;
-            } else {
-                self.execute(
-                    "INSERT INTO config (keyname, value) VALUES (?, ?);",
-                    (key, value),
-                )
-                .await?;
-            }
+            self.execute(
+                "INSERT INTO config (keyname, value) VALUES (?, ?)
+                 ON CONFLICT (keyname)
+                 DO UPDATE SET value=excluded.value",
+                (key, value),
+            )
+            .await?;
         } else {
-            self.execute("DELETE FROM config WHERE keyname=?;", (key,))
+            self.execute("DELETE FROM config WHERE keyname=?", (key,))
                 .await?;
         }
         lock.insert(key.to_string(), value.map(|s| s.to_string()));
@@ -608,7 +601,7 @@ impl Sql {
 
         let mut lock = self.config_cache.write().await;
         let value = self
-            .query_get_value("SELECT value FROM config WHERE keyname=?;", (key,))
+            .query_get_value("SELECT value FROM config WHERE keyname=?", (key,))
             .await
             .context(format!("failed to fetch raw config: {key}"))?;
         lock.insert(key.to_string(), value.clone());

src/sql/migrations.rs

@@ -362,22 +362,6 @@ UPDATE chats SET protected=1, type=120 WHERE type=130;"#,
         .await?;
     }
 
-    if dbversion < 71 {
-        if let Ok(addr) = context.get_primary_self_addr().await {
-            if let Ok(domain) = EmailAddress::new(&addr).map(|email| email.domain) {
-                context
-                    .set_config(
-                        Config::ConfiguredProvider,
-                        get_provider_by_domain(&domain).map(|provider| provider.id),
-                    )
-                    .await?;
-            } else {
-                warn!(context, "Can't parse configured address: {:?}", addr);
-            }
-        }
-
-        sql.set_db_version(71).await?;
-    }
     if dbversion < 72 && !sql.col_exists("msgs", "mime_modified").await? {
         sql.execute_migration(
             r#"
@@ -785,6 +769,27 @@ CREATE INDEX msgs_status_updates_index2 ON msgs_status_updates (uid);
         .await?;
     }
 
+    if dbversion < 106 {
+        // Recreate `config` table with UNIQUE constraint on `keyname`.
+        sql.execute_migration(
+            r#"
+CREATE TABLE new_config (
+  id INTEGER PRIMARY KEY,
+  keyname TEXT UNIQUE,
+  value TEXT
+);
+INSERT OR IGNORE INTO new_config SELECT
+  id, keyname, value
+FROM config;
+DROP TABLE config;
+ALTER TABLE new_config RENAME TO config;
+CREATE INDEX config_index1 ON config (keyname);
+"#,
+            106,
+        )
+        .await?;
+    }
+
     let new_version = sql
         .get_raw_config_int(VERSION_CFG)
         .await?