From 9dc344274b77f7b7cba486df02bc773773cdf2b9 Mon Sep 17 00:00:00 2001 From: Evgeniy Date: Sun, 6 Jan 2019 16:02:32 +0300 Subject: [PATCH 1/6] core.scaleService: more accurate module dependency management --- src/core/core.scaleService.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/core.scaleService.js b/src/core/core.scaleService.js index fe945382003..5e9be1070a0 100644 --- a/src/core/core.scaleService.js +++ b/src/core/core.scaleService.js @@ -1,7 +1,7 @@ 'use strict'; var defaults = require('./core.defaults'); -var helpers = require('../helpers/index'); +var helpers = require('../helpers/helpers.core'); var layouts = require('./core.layouts'); module.exports = { From 10bd94e0f2aebf31879e89adf06dec97fdcaba59 Mon Sep 17 00:00:00 2001 From: Evgeniy Date: Sun, 6 Jan 2019 16:09:09 +0300 Subject: [PATCH 2/6] core.layout: more accurate module dependency management --- src/core/core.layouts.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/core.layouts.js b/src/core/core.layouts.js index b99612bbebd..44ef9025c1d 100644 --- a/src/core/core.layouts.js +++ b/src/core/core.layouts.js @@ -1,6 +1,6 @@ 'use strict'; -var helpers = require('../helpers/index'); +var helpers = require('../helpers/helpers.core'); function filterByPosition(array, position) { return helpers.where(array, function(v) { From c96409629016890bfb10aaf393354cf03f3a9b55 Mon Sep 17 00:00:00 2001 From: Evgeniy Date: Sun, 6 Jan 2019 14:55:35 +0300 Subject: [PATCH 3/6] Dispatch canvas related helpers to helpers.canvas --- samples/advanced/data-labelling.html | 4 +- samples/charts/bar/horizontal.html | 2 +- samples/charts/bar/vertical.html | 2 +- samples/charts/bubble.html | 2 +- samples/charts/polar-area.html | 2 +- samples/charts/radar-skip-points.html | 2 +- samples/charts/radar.html | 2 +- samples/charts/scatter/basic.html | 2 +- samples/charts/scatter/multi-axis.html | 2 +- samples/legend/point-style.html | 2 +- samples/legend/positioning.html | 2 +- samples/scales/logarithmic/scatter.html | 2 +- samples/scales/time/combo.html | 2 +- samples/scales/time/financial.html | 2 +- samples/scales/time/line-point-data.html | 2 +- samples/scales/time/line.html | 2 +- samples/tooltips/custom-points.html | 2 +- src/controllers/controller.bubble.js | 4 +- src/controllers/controller.line.js | 4 +- src/controllers/controller.radar.js | 4 +- src/core/core.animations.js | 2 +- src/core/core.datasetController.js | 2 +- src/core/core.helpers.js | 103 -------------------- src/core/core.scale.js | 8 +- src/core/core.tooltip.js | 12 +-- src/helpers/helpers.canvas.js | 108 +++++++++++++++++++++ src/platforms/platform.dom.js | 2 +- src/scales/scale.radialLinear.js | 2 +- test/specs/controller.bar.tests.js | 12 +-- test/specs/core.helpers.tests.js | 112 ---------------------- test/specs/helpers.canvas.tests.js | 116 +++++++++++++++++++++++ 31 files changed, 268 insertions(+), 259 deletions(-) diff --git a/samples/advanced/data-labelling.html b/samples/advanced/data-labelling.html index 52eb07b8fd3..5c4dfaf811d 100644 --- a/samples/advanced/data-labelling.html +++ b/samples/advanced/data-labelling.html @@ -21,7 +21,7 @@