You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm new to contributing to this project but I've been looking at this issue and I was thinking we could use the uid of each chart to create this unique title. One way to do this would be to modify createResizer() to accept chart id as the second argument. So we would have to change this:
function createResizer(handler) {
var iframe = document.createElement('iframe');
iframe.className = 'chartjs-hidden-iframe';
to something like:
function createResizer(handler, chartId) {
var iframe = document.createElement('iframe');
iframe.title = 'Resizer Frame for Chart ' + chartId;
iframe.className = 'chartjs-hidden-iframe';
Also, inside addResizeListener, we would have to change the call to createResizer:
function addResizeListener(node, listener, chart){
// ....
stub.resizer = createResizer(notify, chart.id);
Any thoughts? I'm very new to this project so forgive me if I'm missing something major in here.
@devjeetr I don't think the resizer should be bound to the chart id since it will soon be possible to share the same resizer between multiple charts. Instead, I would keep it simple and set a generic (and short) title (e.g. title="chartjs-iframe"). Anyway, this iframe is going to be replaced by divs hopefully soon.
Expected Behavior
Frames must have unique title attribute
https://dequeuniversity.com/rules/axe/1.1/frame-title
Current Behavior
Possible Solution
The text was updated successfully, but these errors were encountered: