Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors upgrading to v2.6 #4398

Closed
GMaiolo opened this issue Jun 21, 2017 · 2 comments
Closed

Errors upgrading to v2.6 #4398

GMaiolo opened this issue Jun 21, 2017 · 2 comments
Assignees
@etimberg
Labels
help wanted type: bug
Milestone
Version 2.7

Comments

@GMaiolo
Copy link

GMaiolo commented Jun 21, 2017 •
edited
Loading

According to the upgrade changelog, none of my functionality should break (fiddles below):
screenshot from 2017-06-21 16-40-04

Behavior

Errors upgrading

Steps to Reproduce

Working v2.5 fiddle
Not working v2.6 fiddle

Environment

  • Chart.js version: 2.6
@etimberg
Copy link
Member

@GMaiolo the problem here is the legend global setting

Chart.defaults.global.legend = { display: false };

Work-around is to change this to

Chart.defaults.global.legend.display = false;

@etimberg etimberg added this to the Version 2.7 milestone Jun 22, 2017
@etimberg etimberg self-assigned this Jun 22, 2017
@etimberg etimberg mentioned this issue Jun 22, 2017
Merged
@kumarharsh
Copy link

@etimberg there are also things which are broken since 2.5 - see my comment in #3992.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etimberg etimberg

Labels
help wanted type: bug
Projects
None yet
Milestone
Version 2.7
Development

No branches or pull requests
3 participants
@kumarharsh @etimberg @GMaiolo