From 9af0fa58100b778e8ce1a7a9fc96672e4641605c Mon Sep 17 00:00:00 2001 From: bashbunni Date: Tue, 15 Oct 2024 15:11:38 -0700 Subject: [PATCH 1/2] docs: update contributing guidelines --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index cc9fc189..0533f1a2 100644 --- a/README.md +++ b/README.md @@ -734,6 +734,12 @@ the stylesheet-based Markdown renderer. [glamour]: https://github.com/charmbracelet/glamour +## Contributing + +See [contributing][contribute]. + +[contribute]: https://github.com/charmbracelet/lipgloss/contribute + ## Feedback We’d love to hear your thoughts on this project. Feel free to drop us a note! From 9ed2cf0dc06aed8706874efa21012bf1c5c7730b Mon Sep 17 00:00:00 2001 From: bashbunni Date: Fri, 18 Oct 2024 09:31:58 -0700 Subject: [PATCH 2/2] chore(lint): remove nil check on []string --- table/table.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/table/table.go b/table/table.go index 0380149b..7b9b9f4d 100644 --- a/table/table.go +++ b/table/table.go @@ -521,7 +521,7 @@ func (t *Table) constructRows(availableLines int) string { func (t *Table) constructRow(index int, isOverflow bool) string { var s strings.Builder - hasHeaders := t.headers != nil && len(t.headers) > 0 + hasHeaders := len(t.headers) > 0 height := t.heights[index+btoi(hasHeaders)] if isOverflow { height = 1