You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
True story. I'm not 100% sure there even was a Promise.all spec when I wrote this. I don't know when I will have time to fix it, but I don't think it should be too bad. I'd gladly take a PR :)
While debugging an issue in another project, I found that this mocking library doesn't conform to the spec for
Promise.all
Specifically,
Promise.all
should be able to accept a mix of promises and non-promises, but https://github.com/charleshansen/mock-promises/blob/master/lib/mock-promises.js#L245 expects only promises.Essentially:
Should print
foo, bar, null
. But currently it produces the error:The text was updated successfully, but these errors were encountered: