fix: locals.tf.json getting overwritten #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspitzley-czi
approved these changes
Oct 4, 2022
Comment on lines
+228
to
+229
| // only create the locals.tf.json template is one doesn't exist yet | ||
| tfePath := filepath.Join(rootPath, "tfe", "locals.tf.json") |
There was a problem hiding this comment.
could join with path since that already joined the first 2 items:
Suggested change
| // only create the locals.tf.json template is one doesn't exist yet | |
| tfePath := filepath.Join(rootPath, "tfe", "locals.tf.json") | |
| // only create the locals.tf.json template if one doesn't exist yet | |
| tfePath := filepath.Join(path, "locals.tf.json") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in the TFE config feature of fogg that was overwritting existing locals.tf.json
Test Plan
Not table tests, but both verify this bug doesn't exist anymore. One verifies the output of locals.tf.json doesn't include "null" values in the string if before an optional argument was provided. The other makes sure that if an existing locals.tf.json exists, we preserve the values.