Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing quotes in allowed accounts #637

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

jakeyheath
Copy link
Contributor

Summary

This PR fixes another template bug where the account ID was referenced as a number instead of a string.

Test Plan

  • make update-golden-files
  • make test

References

% AWS_PROFILE=czi-id make run CMD="import module.aws-account-setup.module.tfe-si.aws_iam_role.role tfe-si"
Acquiring state lock. This may take a few moments...

Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 3, in provider "aws":
   3: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 17, in provider "aws":
  17: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 30, in provider "aws":
  30: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 43, in provider "aws":
  43: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 56, in provider "aws":
  56: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 69, in provider "aws":
  69: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 82, in provider "aws":
  82: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 95, in provider "aws":
  95: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 108, in provider "aws":
 108: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 121, in provider "aws":
 121: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 134, in provider "aws":
 134: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 147, in provider "aws":
 147: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 160, in provider "aws":
 160: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 173, in provider "aws":
 173: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 186, in provider "aws":
 186: provider "aws" {



Error: AWS Account ID not allowed: 009273135997

  on /Users/jheath/Documents/shared-infra/terraform/accounts/shasta-prod/fogg.tf line 199, in provider "aws":
 199: provider "aws" {


make: *** [run] Error 1

@jakeyheath jakeyheath requested a review from a team as a code owner April 26, 2022 21:09
@alexlokshin-czi alexlokshin-czi merged commit 2695b4e into main Apr 26, 2022
@alexlokshin-czi alexlokshin-czi deleted the heathj/fix-quote-allowed-account branch April 26, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants