Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tf doc plugin to circle ci template #619

Merged
merged 5 commits into from
Mar 18, 2022
Merged

feat: Add tf doc plugin to circle ci template #619

merged 5 commits into from
Mar 18, 2022

Conversation

alldoami
Copy link
Contributor

@alldoami alldoami commented Mar 18, 2022 •
edited
Loading

Summary

Installing terraform-docs into circle ci tmpl

References

referencing this change https://github.com/chanzuckerberg/fogg/blob/main/templates/templates/.github/workflows/fogg_ci.yml.tmpl#L29-L37

@alldoami alldoami requested a review from a team as a code owner March 18, 2022 20:51
@alldoami alldoami requested a review from aldengolab March 18, 2022 20:51
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #189672: Add tf docs plugin to circleci fogg.

@alldoami alldoami removed the request for review from aldengolab March 18, 2022 20:52
@alldoami alldoami requested a review from jakeyheath March 18, 2022 21:54
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@d16a700). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage        ?   54.71%           
=======================================
  Files           ?       22           
  Lines           ?     3089           
  Branches        ?        0           
=======================================
  Hits            ?     1690           
  Misses          ?     1235           
  Partials        ?      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16a700...4863d8f. Read the comment docs.

@alldoami alldoami requested review from katyho and edulop91 March 18, 2022 22:02
@jakeyheath jakeyheath merged commit 9e5b8ba into main Mar 18, 2022
@jakeyheath jakeyheath deleted the adoami/sc-189672/add-tf-docs-plugin-to-circleci-fogg branch March 18, 2022 22:39
@czi-github-helper czi-github-helper bot mentioned this pull request Mar 21, 2022
Merged
katyho
katyho reviewed Mar 28, 2022
View reviewed changes
templates/templates/circleci/.circleci/config.yml.tmpl
curl -sSLo ./terraform-docs.tar.gz https://github.com/terraform-docs/terraform-docs/releases/download/v0.16.0/terraform-docs-v0.16.0-linux-amd64.tar.gz
tar -xzf terraform-docs.tar.gz
chmod +x terraform-docs
echo "$PWD" >> $GITHUB_PATH
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alldoami I think GITHUB_PATH is a github action specific thing https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path . Getting an error when trying to update fogg :( https://app.circleci.com/pipelines/github/FB-PLP/terraform-infra-management/8174/workflows/1bc186e9-befd-4527-8c52-07a7f812128a/jobs/8183

I don't know if there's an equivalent for circleci?

@katyho katyho mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katyho katyho katyho left review comments

@jakeyheath jakeyheath Awaiting requested review from jakeyheath

@edulop91 edulop91 Awaiting requested review from edulop91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alldoami @katyho @jakeyheath