Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram bars are often different widths and each histogram has a different number of bars #1082

Closed
liaprins-czi opened this issue Jan 2, 2020 · 2 comments · Fixed by #1086
Closed

Histogram bars are often different widths and each histogram has a different number of bars #1082

liaprins-czi opened this issue Jan 2, 2020 · 2 comments · Fixed by #1086
Assignees
@mweiden @colinmegill

Comments

@liaprins-czi
Copy link

#1042 may be relevant

Bar widths, sizes, and position inconsistent across histograms, particularly post-clipping.

  • Left most bar is cut off, needs margin
  • Right most bar is sometimes larger than others
  • ↓ Sometimes bin count appears to be different between different histograms

Screen Shot 2019-08-22 at 2 26 10 PM
@mweiden
Copy link
Contributor

mweiden commented Jan 2, 2020 •
edited
Loading

One clue: this seems to be an issue with the way that the bins are actually generated rather than how they are rendered.

That histograms may have a different number of bins may be a non-issue.

@bkmartinjr
Copy link
Contributor

I looked at this a long time ago, and if memory serves, it is a d3 behavior (or how we use d3). That said, we should definitely fix it.

mweiden added a commit that referenced this issue Jan 2, 2020
@mweiden
Specify histogram thresholds in fixed-length array
d53a799 
Fixes #1082

For background, see the following:
* d3/d3-array#46
* https://stackoverflow.com/questions/15880058/d3-js-ticks-function-giving-more-elements-than-needed
@mweiden mweiden mentioned this issue Jan 2, 2020
Merged
mweiden added a commit that referenced this issue Jan 6, 2020
@mweiden
Specify histogram thresholds in fixed-length array
b5ed552 
Fixes #1082

For background, see the following:
* d3/d3-array#46
* https://stackoverflow.com/questions/15880058/d3-js-ticks-function-giving-more-elements-than-needed
mweiden added a commit that referenced this issue Jan 6, 2020
@mweiden
Specify histogram thresholds in fixed-length array (#1086)
4c1ecf9 
* Specify histogram thresholds in fixed-length array

Fixes #1082

For background, see the following:
* d3/d3-array#46
* https://stackoverflow.com/questions/15880058/d3-js-ticks-function-giving-more-elements-than-needed

* Oops, off by one!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mweiden mweiden

@colinmegill colinmegill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Specify histogram thresholds in fixed-length array chanzuckerberg/cellxgene
4 participants
@mweiden @colinmegill @bkmartinjr @liaprins-czi