Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try changing StateDiff to be BTreeMap instead of Vec to avoid conversions in between #1559

Open
yaziciahmet opened this issue Dec 5, 2024 · 1 comment

Comments

@yaziciahmet
Copy link
Contributor

Both in native and zk, we constantly change convert one to another to ensure unique keys in the state diff. Main reason we change to Vec is to be able to serialize it. Instead of this, we can have some sort of BTreeMap wrapper structure, which implements its own fast serialization.

@kpp kpp self-assigned this Jan 17, 2025
@kpp
Copy link
Contributor

kpp commented Jan 17, 2025

Do we really need this issue given that soon we will have statefull stdiff implemented?

@kpp kpp removed their assignment Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants