fix: Invalid Date object will throw a TypeError (#58) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
reviewed
Nov 4, 2022
|
@keithamus Any reason to why the CI stuff is not running? |
|
I needed to approve it for running. It's running now |
|
I also ran the Karma test suite against IE 11 on Windows 10 successfully. |
dotnetCarpenter
force-pushed
the
fix-invalid-date-object-will-throw-a-typeerror
branch
from
309fa36 to
6f0c55f
Compare
keithamus
approved these changes
Nov 5, 2022
Codecov ReportBase: 75.36% // Head: 75.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 75.36% 75.43% +0.07%
==========================================
Files 19 19
Lines 625 631 +6
==========================================
+ Hits 471 476 +5
- Misses 154 155 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
🎉 This PR is included in version 2.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make sure that
loupewill return"Invalid Date"if aDateobject is invalid. It does not deal with how theDateobject became invalid as that depends on JS engine.See #58 (comment) for a comparison between V8 and Firefox's SpiderMoney.