Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

[Feature] Bulk upgrade/evolve of Pokemon #28

Open
Senney opened this issue Jul 29, 2016 · 5 comments
Open

[Feature] Bulk upgrade/evolve of Pokemon #28

Senney opened this issue Jul 29, 2016 · 5 comments
Assignees

Comments

@Senney
Copy link

Senney commented Jul 29, 2016

Great app, loving it so far!

I've started implementing this myself, so maybe I can submit it as a pull request once I've got it complete.

It would be great to be able to quickly Upgrade a specific Pokemon a specified number of times, or until you run out of candies/dust. Same idea with Evolving, except evolve all Pokemon of a single type (useful for cases where you're farming XP or have popped an egg). I've started work on this, and it seems to be doable using the UpgradePokemonMessage_pb2 and EvolvePokemonMessage_pb2 messages.

I'll submit a Pull Request some time this weekend or early next week with my implementation.

@Senney Senney changed the title Bulk upgrade/evolve of Pokemon [Feature] Bulk upgrade/evolve of Pokemon Jul 29, 2016
@cglatot
Copy link
Owner

cglatot commented Jul 30, 2016

You shouldn't need to go to the protobufs at all, there are methods in Session that allow you to evolve. Look at the API for info. And look at their demo.py - it has evolve demos in there: https://github.com/rubenvereecken/pokemongo-api

If you are going to submit a pull request for this make sure you do the following:

  • Check for number of candies and calculate how many evolutions can happen for that pokemon (and display to user)
  • Correctly deduct candies when evolving (or make sure that you don't try to evolve more than can be evolved)
  • Allow the user to specify how many to evolve for each pokemon
  • Allow the user to specify a certain Pokemon (and how many to evolve), or to evolve everything available (or at the very least, code it in a way that the second feature could be added on easily enough)

If you meet those criteria, and it follows similar formatting / tabular layout as the rest I'll be happy to merge. Looking at the transfer and counts methods will likely provide most of the code for it anyway.

@cglatot cglatot self-assigned this Jul 30, 2016
@fprovostpoulin
Copy link

fprovostpoulin commented Aug 3, 2016

Is there a way to ask to activate a lucky egg before starting the evolutions ? That way you can as well tell if you have the optimal number of upgrades.

Also, it may be nice to have an option to filter by How much candy it requires... that way we could focus on just pidgey, caterpies and weedles if we want (Or as it'S done in the "Transfer" option, maybe ask for what pokemon we want to evolve, and how many of them starting by the higher IV maybe )

@MatyiFKBT
Copy link

@fprovostpoulin maybe you need to activate the egg on your phone and than run the code on your computer. If you don't happen to have thousands of Pokémons, it should be done in 30 minutes.

@fprovostpoulin
Copy link

can't we use session.evolvePokemon(monster[6]) in order to do it ? I didn't succeed to evolve through this method. Any help ?

@BeardAnnihilator
Copy link

#59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants